Repository navigation
Adds the waiting loan's diff cases, one per class - #348
Merged
Merged
Conversation
Three authored cases under conformance/cases/diff/ take a loan that waits in awaiting_return with its due-date timer handed to the host, while its chart is edited so that the check_in state routing after the wait gains a damaged outcome: a damaged key, an in_repair final state and the transition to it. Each case carries expect_diff and expect_compatible_at for the position the loan waits at: - loan_waiting_across_a_damaged_arm: awaiting_return keeps its id; the pair is compatible and the predicate answers true. - loan_waiting_across_a_mapped_rename: awaiting_return becomes awaiting_check_in, diffed with a mapping; the pair is mapped and the predicate answers false, since it takes no mapping. - loan_waiting_across_a_regrouping: awaiting_return keeps its id but is gathered with overdue under a new compound state; the pair is breaking and the predicate answers false. The corpus is re-emitted with mix statifier.corpus: the statifier suite goes from 28 to 31 cases and the corpus hash moves. The three cases are ratcheted in with mix test.baseline add, so the registry's statifier claim names them. conformance/README.md describes the loan pairs beside the hold_queue ones. No lib/ change. No changelog fragment: conformance fixtures. Refs: st-j1x8
loan_waiting_across_a_damaged_arm said the waiting step was renamed in the name a reader sees. The pair has no rename of any kind: awaiting_return is byte-identical in both charts, and a chart carries no reader-facing name. The sentence now says awaiting_return is unchanged, id and content alike, and that the damaged outcome is the only edit. Corpus re-emitted with mix statifier.corpus; --check passes. Refs: st-j1x8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds diff and position cases for a library loan that waits in
awaiting_returnwith its due-date timer handed to the host, while its chart is edited so that thecheck_instate routing after the wait gains a damaged outcome (adamagedkey, anin_repairfinal state and the transition to it). One case per class, each withexpect_diffandexpect_compatible_atfor the position the loan waits at:awaiting_returnloan_waiting_across_a_damaged_armloan_waiting_across_a_mapped_renameawaiting_check_in, with a mappingloan_waiting_across_a_regroupingoverdueunder a new compound stateThe expected reasons are the ones
Statifier.Chart.diff/3answers today, order included;test/corpus/diff_cases_test.exscompares them over the committed corpus.mix statifier.corpus:manifest.json's statifiercase_countgoes from 28 to 31, the corpus hash moves;mix statifier.corpus --checkpasses.conformance/README.md: the diff-case paragraph now says the pairs take ahold_queueor aloanchart, and a new paragraph describes the loan pairs.lib/change (git diff origin/main --stat -- libis empty). No changelog fragment:changelog.d/README.mdexcludes conformance fixtures. No release.Provenance
awaiting_returnis unchanged, id and content alike: the damaged outcome is the only edit, which is what makes the pair compatible. An id change is the Mapped case.hold_queuerename-without-mapping case.test/passing_tests.jsonwithmix test.baseline add, andregistry.jsonis re-emitted, so the registry's statifier claim names them as it names every other authored case. The file map did not name this; it keeps the claim complete.stepsis empty), ashold_queue_identicalandhold_queue_data_addeddo; the library world gains no event.Checks
mix quality, full, green on the head tree (re-run after the description correction): 3,067 of 3,067 tests passed, Dialyzer, Credo, conformance corpus and regression ratchet all passed.mix quality --profile mergegreen on the first commit; the ADR judge skipped (no file in a judged scope).expect_compatible_atflipped to false in the corpus file -> the position test red, naming that case; the breaking case's class changed to compatible -> the diff test red, naming that case.Review tier: contract (a corpus expectation).