Conversation
The comment beside the Docs and Doc links stages said the Doc links stage fails on "a published relative link to a file that is not an extra", which reads as covering moduledoc links too. The stage reads relative links in the Markdown extras and the README only; moduledoc links are the Docs stage's. The comment now carries the wording the other packages in the family use. No stage option changes. The gate-change log gains the entry the Gate guard requires, with its Approved-by line left for the operator to fill. Refs: st-1kyb
Member
Author
|
Superseded by #351, which carries this change with the operator's approval filled in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewords the comment beside the
doc_linksstage in.quality.exs(st-1kyb).Draft until the operator fills in Approved-by.
What changed
.quality.exs: the comment beside the Docs and Doc links stages said the Doc links stage fails on "a published relative link to a file that is not an extra", which reads as covering moduledoc links too. The stage reads relative links in the Markdown extras and the README only; moduledoc links are the Docs stage's. The comment now carries the same wording as the other packages in the family. No stage option changes.docs/quality-gate-changes.md: the ADR-0011 entry for that edit, withApproved-by: <operator to fill>for the operator to complete. The entry is left for the operator because writing the approval is not an agent's call.No changelog fragment: the change is gate tooling, which
changelog.d/README.mdexcludes. No version bump.Evidence
mix qualitygreen on the committed tree, placeholder included: Gate guard "No unjustified gate changes", Doc links 37 links checked, Docs no warnings, 3,067 of 3,067 tests passed, 96.3% coverage, Dialyzer clean. The Gate guard checks that anApproved-by:line is present, not what it says, so the placeholder does not turn it red.mix gate.check: no unjustified gate changes.mix quality --profile mergegreen; the ADR judge skipped because the diff touches none of its judged scopes.For the operator
Replace the placeholder on the
Approved-by:line indocs/quality-gate-changes.md, then mark the PR ready.