Brings the gate stage section up to date - #234
Merged
Merged
Conversation
The "When a stage fails" section of CLAUDE.md named the ex_quality constraint from before the move to 0.15 and listed six stages. It now names the constraint mix.exs carries (~> 0.15) and the eight stages a bare mix quality runs here: the six it listed plus Docs and Doc links, which .quality.exs enables at :auto and which run because ex_doc is a dev dependency. The three expected skips are unchanged. Documentation only: no behaviour, gate or version change, and no changelog fragment (changelog.d/README.md excludes documentation). Refs: px-wm2w
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The "When a stage fails" section of
CLAUDE.mdnow:mix.exscarries,{:ex_quality, "~> 0.15"}(it said~> 0.14);mix qualityruns here - Format, Compile, Dependencies, Credo, Tests, Dialyzer, Docs, Doc links - where it listed six. The three expected○ skipped (not installed)stages (Doctor, Gettext, Sobelow) are unchanged.No other line of the section moves.
Refs: px-wm2w
Review (in-turn)
Checked against the bead's acceptance ("the sentence names the constraint mix.exs carries and the stage list matches a bare mix quality run"):
mix.exs@depscarries{:ex_quality, "~> 0.15", only: :dev, runtime: false};mix.lockresolves it to 0.15.1.Mix.Tasks.Qualityalways runs Format and Compile, then the@analysis_stageslist (Credo, Dialyzer, Doctor, Docs, Doc links, Gettext, Sobelow, Dependencies) plus Tests..quality.exssetsdocs: [enabled: :auto]anddoc_links: [enabled: :auto], andExQuality.Configdetects both from:ex_doc, whichmix.exscarries as a dev dependency, so both run. Doctor, Gettext and Sobelow are not dependencies, so each is skipped with "not installed", matchinggate.project_level_skipsandgate.not_applicable_skipsin.claude/wurk.json. That leaves eight running stages, which is the new list; the display names are the ones each stage module reports ("Tests", "Docs", "Doc links").mix qualityitself was not run for this change; the list is read from the tool's source at the locked version.Advisory, not changed (outside the bead): the loop-profile bullet in the same section says Dialyzer and the dependency audit do not run under
--profile loop; Docs and Doc links do not run there either. The sentence does not claim to be exhaustive, so it is left as is.Gate
Documentation only (
CLAUDE.mdis outsidegate.build_pathsandgate.also_gated_paths): "a change touching no Elixir code has no gate to run and may commit on review of the diff alone". No changelog fragment (changelog.d/README.mdexcludes documentation).Tier: gate (documentation, no contract surface, a few lines).