Skip to content

Brings the gate stage section up to date - #234

Merged
johnnyt merged 1 commit into
mainfrom
px-wm2w-claude-stage-section
Sep 25, 2026
Merged

johnnyt merged 1 commit into
mainfrom
px-wm2w-claude-stage-section

Conversation

@johnnyt

@johnnyt johnnyt commented Sep 25, 2026

Copy link
Copy Markdown
Member

What changed

The "When a stage fails" section of CLAUDE.md now:

  • names the constraint mix.exs carries, {:ex_quality, "~> 0.15"} (it said ~> 0.14);
  • lists the eight stages a bare mix quality runs here - Format, Compile, Dependencies, Credo, Tests, Dialyzer, Docs, Doc links - where it listed six. The three expected ○ skipped (not installed) stages (Doctor, Gettext, Sobelow) are unchanged.

No other line of the section moves.

Refs: px-wm2w

Review (in-turn)

Checked against the bead's acceptance ("the sentence names the constraint mix.exs carries and the stage list matches a bare mix quality run"):

  • Constraint: mix.exs @deps carries {:ex_quality, "~> 0.15", only: :dev, runtime: false}; mix.lock resolves it to 0.15.1.
  • Stage list, read from ex_quality at the v0.15.1 tag (the locked version) rather than from a remembered run: Mix.Tasks.Quality always runs Format and Compile, then the @analysis_stages list (Credo, Dialyzer, Doctor, Docs, Doc links, Gettext, Sobelow, Dependencies) plus Tests. .quality.exs sets docs: [enabled: :auto] and doc_links: [enabled: :auto], and ExQuality.Config detects both from :ex_doc, which mix.exs carries as a dev dependency, so both run. Doctor, Gettext and Sobelow are not dependencies, so each is skipped with "not installed", matching gate.project_level_skips and gate.not_applicable_skips in .claude/wurk.json. That leaves eight running stages, which is the new list; the display names are the ones each stage module reports ("Tests", "Docs", "Doc links").
  • mix quality itself was not run for this change; the list is read from the tool's source at the locked version.

Advisory, not changed (outside the bead): the loop-profile bullet in the same section says Dialyzer and the dependency audit do not run under --profile loop; Docs and Doc links do not run there either. The sentence does not claim to be exhaustive, so it is left as is.

Gate

Documentation only (CLAUDE.md is outside gate.build_paths and gate.also_gated_paths): "a change touching no Elixir code has no gate to run and may commit on review of the diff alone". No changelog fragment (changelog.d/README.md excludes documentation).

Tier: gate (documentation, no contract surface, a few lines).

The "When a stage fails" section of CLAUDE.md named the ex_quality
constraint from before the move to 0.15 and listed six stages. It now
names the constraint mix.exs carries (~> 0.15) and the eight stages a
bare mix quality runs here: the six it listed plus Docs and Doc links,
which .quality.exs enables at :auto and which run because ex_doc is a
dev dependency. The three expected skips are unchanged.

Documentation only: no behaviour, gate or version change, and no
changelog fragment (changelog.d/README.md excludes documentation).

Refs: px-wm2w
@codecov

codecov Bot commented Sep 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johnnyt
johnnyt merged commit 273c5b9 into main Sep 25, 2026
2 checks passed
@johnnyt
johnnyt deleted the px-wm2w-claude-stage-section branch September 25, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant