Restores the settled block's bullet indent - #121
Merged
Merged
Conversation
The two record bullets in Encryptor.Vault.Encrypt's "Flagged, not settled" section lost their hanging indent when the block was rewritten to hold its line range. They are back in the file's style, two-space bullets with four-space continuation, and the block still runs from the heading at :57 to :84, the range ADR-0002 Amendment A cites. The section quotes the vault's ordering rule, but no record carried the sentence. A dated foot Note on ADR-0001 records it verbatim and cites, by anchor, where the encrypt path follows each step; the comment now points at that Note. No record line is removed and no decision changes. Comment and record only, so no changelog fragment. Refs: enc-6n8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two fixes to the "Flagged, not settled: the provider is consulted on every call (settled 2026-09-13)" comment section in
Encryptor.Vault.Encrypt, plus one dated foot Note on ADR-0001.Encryptor.Vault.Suspension's comment bullets use. Only leading whitespace changes on those lines. The block still starts with its heading at:57and ends at:84, the range and heading string ADR-0002 Amendment A cites.Comment and record only: no behaviour changes and no changelog fragment (
changelog.d/README.mdexcludes documentation and ADRs).Provenance
maybe_caching/3callsPartition.id/2and thecache: falseclause skips it. It reports what the code does and decides nothing.Review (in-turn, gate tier)
I read the diff against the bead's two acceptance items and checked every anchor in the Note against
lib/at827c6d3, the base of this branch;lib/is byte-identical between32234d6and that commit.Resolve.encryption_key/3is called inside the provider span atencrypt.ex:141,Keyring.build/3at:143, andResolve.context/5at:144.Keyring.build/3's catch-all refusal is atkeyring.ex:120, andPartition.id/2is called insidemaybe_caching/3atencrypt.ex:192.client/3is defined at:173andstack/3at:160. The edit adds and removes no lines inencrypt.ex, so every anchor stays put, including ADR-0001's own cites ofencrypt.ex:59-84,:162-164and:184-194.git diff origin/main -- docs/adr/shows zero removed lines, and the Note sits after the file's last heading.mix qualityis green on the committed tree (673 tests, Credo, Docs, doc links, Dialyzer). The gate lock and a machine slot were held for that run, and the staged tree is byte-identical to the tree that ran, so the commit was made without a second run.