fix: inbound attachment types#211
Merged
Merged
Conversation
Signed-off-by: gabriel miranda <gabrielmfern@outlook.com>
Signed-off-by: gabriel miranda <gabrielmfern@outlook.com>
Signed-off-by: gabriel miranda <gabrielmfern@outlook.com>
Contributor
There was a problem hiding this comment.
No issues found across 9 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: This PR restructures attachment type definitions (renaming models, changing field types to Literal and NotRequired, and moving fields), which is a refactor that could break existing SDK consumers relying on the previous type shapes.
Re-trigger cubic
drish
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: gabriel miranda gabrielmfern@outlook.com
Summary by cubic
Align inbound and signed-URL attachment types with the API to remove response type mismatches. Includes nullable inbound fields per DEV-934 and adds a clear model for signed URL responses.
AttachmentWithSignedUrlfor list/retrieve attachment endpoints, includingdownload_url,expires_at, requiredsize, andcontent_dispositionas"inline"or"attachment".EmailAttachmentfor inbound emails to allowfilename,content_id, andcontent_dispositionto be null;sizeis optional/nullable.resend.emails._attachmentsandresend.emails._receivingto returnList[AttachmentWithSignedUrl].AttachmentWithSignedUrlinresend/__init__.py.download_url/expires_atand nullable inbound attachment fields.Written for commit 6a6494c. Summary will update on new commits.