Repository navigation
Conversation
Changelog🐛 Bug fix
Semantic Diff8 commits · Full page Complete the constructors of extensible variants6144dd2 · cknitt + Claude · Oct 27, 2026, 13:06 UTC
Diagnostic modified (completion of an extensible variant) type attr = ..
type attr += Str(string) | Num(int)
// let a: attr = Nu
-Nullable, Null
+Num(_), Nullable, NullDiagnostic modified (exhaustive switch snippet) let value: attr = Str("s")
// switch valu
switch value {
| Str(_) => %todo
| Num(_) => %todo
| Flag => %todo
| _ => %todo
}Review
Match extension constructors by type and name them by module pathae2da18 · cknitt + Claude · Oct 27, 2026, 17:50 UTC Codex review on #9085: extensions were matched to an open type by its last name only, so Name extension constructors relative to where completion runsb258851 · cknitt + Claude · Oct 27, 2026, 20:29 UTC Codex review on #9085: extension constructors were named relative to the root of their file and to the file of the completed value. Inside the declaring module that inserted Qualify extension constructors of namespaced modules by source pathb9d5edc · cknitt + Claude · Oct 27, 2026, 21:45 UTC Codex review on #9085: the module name of another file comes from its compiled name, which in a namespaced project is Offer extensions in scope at the cursor and from interface modules84e1386 · cknitt + Claude · Oct 28, 2026, 07:47 UTC Codex review on #9085: an extension of the edited file declared after the cursor was offered although it isn't in scope there, and an extension inside a module of an interface ( Qualify extensions of nested interface modules and complete their payloads3cb8834 · cknitt + Claude · Oct 29, 2026, 06:34 UTC Codex review on #9085: an extension two modules deep in an interface got only the outer module in its path, because the signature walk didn't extend the module path when entering a module, and completion inside the payload of a qualified constructor such as Type extension payloads in their own file and match qualified constructors462f92c · cknitt + Claude · Oct 29, 2026, 10:10 UTC Codex review on #9085: a payload type declared next to the extension, as in ✨ Look up unqualified extension payloads in the scope at the cursorb119166 · cknitt + Claude · Oct 29, 2026, 10:33 UTC · new Codex review on #9085: ranking same-named extension constructors let an open outrank a local extension declared after it, so after |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9085 +/- ##
==========================================
+ Coverage 81.45% 81.51% +0.05%
==========================================
Files 460 460
Lines 64645 64862 +217
==========================================
+ Hits 52657 52871 +214
- Misses 11988 11991 +3
🚀 New features to boost your workflow:
|
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-9085 |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98ecc79d93
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex review on #9085: extensions were matched to an open type by its last name only, so `A.t` got the constructors of `B.t`, and a constructor declared in a nested module was inserted without its module, which doesn't compile because an extension constructor can't be found from the expected type. An extension now records the type it extends and is matched by that type's file and stamp, and it is named by its module path, for example `Sub.Flag`; a prefix may match the last part. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gLMawVgtmiKy3TMBc3 Signed-off-by: Christoph Knittel <ck@cca.io>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f678bb32e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex review on #9085: extension constructors were named relative to the root of their file and to the file of the completed value. Inside the declaring module that inserted `Sub.Flag`, which is not in scope there, and for a value imported from another file the constructors were not qualified with its module, while extensions in the edited file were missed. A completion request now records the edited file and the module path at the cursor; constructors of that file drop the module path shared with the cursor, constructors of other files get their module's name, and extensions are collected from the edited file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gLMawVgtmiKy3TMBc3 Signed-off-by: Christoph Knittel <ck@cca.io>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56cff12ba2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex review on #9085: the module name of another file comes from its compiled name, which in a namespaced project is `Base-MyNamespace`, so completion inserted `Base-MyNamespace.Flag`. The name is turned into its source path `MyNamespace.Base` first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gLMawVgtmiKy3TMBc3 Signed-off-by: Christoph Knittel <ck@cca.io>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3408b27a6e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Why:
Editor analysis didn't record the constructors added by `type t += ...`,
and an open type has none in its declaration, so completion offered no
constructor where a value of the type was expected. They are now
registered as constructors of an open type, and typed completion of an
open type offers those declared in the type's file and in the current
file. Since other files can extend the type, the exhaustive switch
snippet for one adds a `_` case.
Diagnostic modified (completion of an extensible variant):
Example:
type attr = ..
type attr += Str(string) | Num(int)
// let a: attr = Nu
Before (text): tests/analysis_tests/tests/src/CompletionExtensibleVariant.res
Nullable, Null
After (text): tests/analysis_tests/tests/src/CompletionExtensibleVariant.res
Num(_), Nullable, Null
Diagnostic modified (exhaustive switch snippet):
Example:
let value: attr = Str("s")
// switch valu
After (rescript):
switch value {
| Str(_) => %todo
| Num(_) => %todo
| Flag => %todo
| _ => %todo
}
Review: Which extensions are offered?
Those in the file that declares the type and in the current file;
an extension in a third file is not known to the current file's
analysis.
Fixes: #9073
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Kbf3gLMawVgtmiKy3TMBc3
Signed-off-by: Christoph Knittel <ck@cca.io>
Codex review on #9085: extensions were matched to an open type by its last name only, so `A.t` got the constructors of `B.t`, and a constructor declared in a nested module was inserted without its module, which doesn't compile because an extension constructor can't be found from the expected type. An extension now records the type it extends and is matched by that type's file and stamp, and it is named by its module path, for example `Sub.Flag`; a prefix may match the last part. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gLMawVgtmiKy3TMBc3 Signed-off-by: Christoph Knittel <ck@cca.io>
Codex review on #9085: extension constructors were named relative to the root of their file and to the file of the completed value. Inside the declaring module that inserted `Sub.Flag`, which is not in scope there, and for a value imported from another file the constructors were not qualified with its module, while extensions in the edited file were missed. A completion request now records the edited file and the module path at the cursor; constructors of that file drop the module path shared with the cursor, constructors of other files get their module's name, and extensions are collected from the edited file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gLMawVgtmiKy3TMBc3 Signed-off-by: Christoph Knittel <ck@cca.io>
Codex review on #9085: the module name of another file comes from its compiled name, which in a namespaced project is `Base-MyNamespace`, so completion inserted `Base-MyNamespace.Flag`. The name is turned into its source path `MyNamespace.Base` first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gLMawVgtmiKy3TMBc3 Signed-off-by: Christoph Knittel <ck@cca.io>
Codex review on #9085: an extension of the edited file declared after the cursor was offered although it isn't in scope there, and an extension inside a module of an interface (`module Sub: { type attr += Flag }`) was never registered, because only typed-tree extensions were. The completion scope now records the cursor position and skips later extensions of the edited file, and extensions in signatures are registered too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gLMawVgtmiKy3TMBc3 Signed-off-by: Christoph Knittel <ck@cca.io>
3408b27 to
84e1386
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84e1386175
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…loads Codex review on #9085: an extension two modules deep in an interface got only the outer module in its path, because the signature walk didn't extend the module path when entering a module, and completion inside the payload of a qualified constructor such as `Sub.Toggle(...)` found no constructor, because the payload position keeps only `Toggle`. Signature modules now extend the path, and payload lookup also matches the last part of a qualified constructor name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gLMawVgtmiKy3TMBc3 Signed-off-by: Christoph Knittel <ck@cca.io>
|
@codex review |
1 similar comment
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3cb8834566
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ctors Codex review on #9085: a payload type declared next to the extension, as in `type Base.attr += Color(color)` with a local `color`, was resolved in the open type's file, so payload completion lost it; and of two same-named extensions, `B.Value(...)` completed the payload of the first one, `A.Value`, because the payload position kept only `Value`. Each extension constructor now carries the environment of its file, and the payload position keeps the written path: the constructor sharing the longest suffix with it is meant, ties going to the most recent open, then to the last declared one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gGkPma9LAZimuQjnrP Signed-off-by: Christoph Knittel <ck@cca.io>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 462f92c4a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex review on #9085: ranking same-named extension constructors let an open outrank a local extension declared after it, so after `open A` and a later local `Value(...)`, completion used `A.Value`'s payload; and an extension inside a module type, `module type S = { type attr += Phantom }`, was offered as `S.Phantom` and added to exhaustive switches. A qualified constructor is now the one its written path names, and an unqualified one is looked up in the completion scope as the compiler does, which now records extension constructors, the most recent declaration or open winning. Extensions in module types are skipped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gGkPma9LAZimuQjnrP Signed-off-by: Christoph Knittel <ck@cca.io>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1191669a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ( Tvariant | ||
| { | ||
| env = env_from_item; | ||
| constructors = List.map fst extension_envs; | ||
| extension_envs; |
There was a problem hiding this comment.
Preserve catch-all cases in open-variant refactors
Returning Tvariant for open types also enables Xform.Expand_catch_all_for_variants.xform, which replaces the wildcard with only the listed constructors. For example, after type attr = ..; type attr += Known, applying “Expand catch-all” to switch value { | _ => ... } now removes the fallback and handles only Known. Valid constructors added elsewhere then cause a match failure. Unlike the completion snippet updated in this commit, this code-action consumer does not check Type_open. Preserve the wildcard when expanding an open variant, or exclude open variants from this refactor.
Useful? React with 👍 / 👎.
| match last (named (opened @ path)) with | ||
| | Some c -> Some c | ||
| | None -> lookup scope) |
There was a problem hiding this comment.
Restrict opened payload lookup to the opened module
With A.Value(bool) declared first, a local Value(option<int>) declared next, and then open A, payload completion inside unqualified Value(...) selects the local option constructor instead of the opened boolean constructor. The fresh counterexample reverses the covered local-after-open ordering: the open occurs last and should win. Here, named ["A"; "Value"] accepts both constructors because the reverse suffix comparison also matches the bare local name; last then selects the later local declaration. This affects expression and pattern payload completion. Resolve the opened module's constructor rather than allowing an unrelated bare constructor to match its qualified path.
Useful? React with 👍 / 👎.
Fixes #9073.
Analysis didn't record constructors added by
type t += ..., so completion offered none for an extensible variant. They are now registered as constructors of an open type. Typed completion of an open type, in both expressions and patterns, offers the ones declared in the type's file and in the current file. The exhaustive-switch snippet for an open type ends with a_case, since other files can extend it.New analysis test:
CompletionExtensibleVariant.Constructors are named so that they are in scope where completion runs: unqualified inside their declaring module,
Sub.Flagelsewhere in the file, andModule.Flagfrom another file, using source paths in namespaced projects.Known limitation: an extension declared inside a module whose signature hides it (
module Hidden: {} = { type attr += Flag }) is still offered. Filtering through the visible signature is left for a follow-up.🤖 Generated with Claude Code
https://claude.ai/code/session_01Kbf3gLMawVgtmiKy3TMBc3