Repository navigation
fix(add): center the platform tile icons and labels on the add page - #1295
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Add page, the platform logos in the Add a device and Add an instance grids sat a few pixels to the right of their labels.
Why: The theme centers every list icon inside a fixed 56px box, but these tiles left-align their labels. That put each logo 4–14px right of its text, depending on its width. Narrow logos (Mac, AXIS, Ubuntu, IDY) were off the most.
Fix: Each tile now centers both the icon box and the label. The only file changed is
AddPage.tsx, so other lists keep the theme default.Verified in a local preview of
AddPage: on every tile the icon and label share a center line, and there's no horizontal overflow at 375px. Android's label sits slightly off on its own because the label plus its ScreenView badge is centered as a group.Reported by robo in Slack.