Skip to content

fix(extensions): fix accessibility violations in Extensions plugin#3843

Merged
teknaS47 merged 1 commit into
redhat-developer:mainfrom
its-mitesh-kumar:fix/extensions-3838-accessibility-violations
Jul 21, 2026
Merged

fix(extensions): fix accessibility violations in Extensions plugin#3843
teknaS47 merged 1 commit into
redhat-developer:mainfrom
its-mitesh-kumar:fix/extensions-3838-accessibility-violations

Conversation

@its-mitesh-kumar

Copy link
Copy Markdown
Member

Description

Fix three accessibility violations in the Extensions plugin that were suppressed by the skipFailures flag in e2e accessibility tests:

  1. role-img-alt — MUI CardMedia elements with role="img" lacked an accessible name. Added title attribute using the plugin display name to PluginIcon.
  2. aria-prohibited-attr — Badge triangle tooltip wrappers (BadgeTriange) had aria-label forwarded to a plain <div> with no role. Added role="img" and explicit aria-label to the tooltip child element.
  3. label — Filter combobox inputs (Category, Author, Support type) had no associated labels. Added id prop to Autocomplete and htmlFor to InputLabel in CustomSelectFilter to create proper label associations.

Also removed the skipFailures flag from e2e-tests/utils/accessibility.ts so the e2e suite now enforces full WCAG 2.x accessibility.

Fixed

UI before changes

Before fix

UI after changes

After fix

Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

Note

This bug fix was identified and implemented using the bug-fix and raise-pr agent skills. Please verify the fix thoroughly before merging.

@rhdh-gh-app

rhdh-gh-app Bot commented Jul 19, 2026

Copy link
Copy Markdown

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-extensions workspaces/extensions/plugins/extensions patch v0.18.1

@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.59%. Comparing base (f8f09d1) to head (d6e3266).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3843   +/-   ##
=======================================
  Coverage   56.59%   56.59%           
=======================================
  Files        2372     2372           
  Lines       95021    95023    +2     
  Branches    26591    26598    +7     
=======================================
+ Hits        53777    53779    +2     
  Misses      39700    39700           
  Partials     1544     1544           
Flag Coverage Δ *Carryforward flag
adoption-insights 84.54% <ø> (ø) Carriedforward from f8f09d1
ai-integrations 69.26% <ø> (ø) Carriedforward from f8f09d1
app-defaults 69.79% <ø> (ø) Carriedforward from f8f09d1
augment 46.67% <ø> (ø) Carriedforward from f8f09d1
boost 75.27% <ø> (ø) Carriedforward from f8f09d1
bulk-import 72.59% <ø> (ø) Carriedforward from f8f09d1
cost-management 13.55% <ø> (ø) Carriedforward from f8f09d1
dcm 60.72% <ø> (ø) Carriedforward from f8f09d1
extensions 56.20% <100.00%> (+0.02%) ⬆️
global-floating-action-button 71.18% <ø> (ø) Carriedforward from f8f09d1
global-header 62.19% <ø> (ø) Carriedforward from f8f09d1
homepage 47.58% <ø> (ø) Carriedforward from f8f09d1
install-dynamic-plugins 56.77% <ø> (ø) Carriedforward from f8f09d1
intelligent-assistant 69.50% <ø> (ø) Carriedforward from f8f09d1
konflux 91.98% <ø> (ø) Carriedforward from f8f09d1
lightspeed 69.02% <ø> (ø) Carriedforward from f8f09d1
mcp-integrations 83.40% <ø> (ø) Carriedforward from f8f09d1
orchestrator 57.01% <ø> (ø) Carriedforward from f8f09d1
quickstart 65.11% <ø> (ø) Carriedforward from f8f09d1
sandbox 79.56% <ø> (ø) Carriedforward from f8f09d1
scorecard 82.66% <ø> (ø) Carriedforward from f8f09d1
theme 83.85% <ø> (ø) Carriedforward from f8f09d1
translations 5.15% <ø> (ø) Carriedforward from f8f09d1
x2a 79.31% <ø> (ø) Carriedforward from f8f09d1

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f09d1...d6e3266. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread workspaces/extensions/e2e-tests/utils/accessibility.ts

@teknaS47 teknaS47 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests including accessibility tests passed.

Image

@sanketpathak

Copy link
Copy Markdown
Contributor

/lgtm

@teknaS47 teknaS47 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .gif files are still present

Fixes: redhat-developer#3838
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@its-mitesh-kumar
its-mitesh-kumar force-pushed the fix/extensions-3838-accessibility-violations branch from 300a59a to d6e3266 Compare July 21, 2026 10:08
@sonarqubecloud

Copy link
Copy Markdown

@teknaS47 teknaS47 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jul 21, 2026
@teknaS47
teknaS47 enabled auto-merge (squash) July 21, 2026 11:18
@teknaS47
teknaS47 merged commit 493df1f into redhat-developer:main Jul 21, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility violations for Extensions plugin

4 participants