fix(redis): Regression for masterauth field causing NOAUTH Authentication required error

[akhilnittala]

What type of PR is this?
/kind bug

What does this PR do / why we need it:
RCA: masterauth has been removed in redis.conf.tpl as part of this pr #1124, but init.sh script use sed command to overwrite REPLACE_DEFAULT_AUTH with password. sed command will replace the existing but field itself is removed, so password is not getting added in redis.confRCA: masterauth has been removed in redis.conf.tpl as part of this pr #1124, but init.sh script use sed command to overwrite REPLACE_DEFAULT_AUTH with password. sed command will replace the existing but field itself is removed, so password is not getting added in redis.conf
Have you updated the necessary documentation?

• Documentation update is required by this PR.
• Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?
https://redhat.atlassian.net/browse/GITOPS-10178
Test acceptance criteria:

• Unit Test
• E2E Test

How to test changes / Special notes to the reviewer:

• Deploy redis with ha enabled, ha.enabled: true
• verify the redis pods are up and check the below commands for ha proxy pods.

kubectl logs -f openshift-gitops-redis-ha-server-1 -n openshift-gitops
oc exec -it openshift-gitops-redis-ha-server-0 -n openshift-gitops -- \
sh -c 'REDISCLI_AUTH=$(cat /app/config/redis-auth/auth) redis-cli INFO replication'
oc exec -it openshift-gitops-redis-ha-server-0  -n openshift-gitops -- cat /data/conf/redis.conf

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: a5320edf-db8b-494c-ab1b-0495e99565ed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[varshab1210]

/lgtm

[svghadi]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [svghadi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment