fix(redis): Regression for masterauth field causing NOAUTH Authentication required error

[akhilnittala]

What type of PR is this?
/kind bug

What does this PR do / why we need it:
RCA: masterauth has been removed in redis.conf.tpl as part of this pr #1124, but init.sh script use sed command to overwrite REPLACE_DEFAULT_AUTH with password. sed command will replace the existing but field itself is removed, so password is not getting added in redis.conf
Have you updated the necessary documentation?

• Documentation update is required by this PR.
• Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?
https://redhat.atlassian.net/browse/GITOPS-10178
Test acceptance criteria:

• Unit Test
• E2E Test

How to test changes / Special notes to the reviewer:

• Deploy redis with ha enabled, ha.enabled: true
• verify the redis pods are up and check the below commands for ha proxy pods.

kubectl logs -f openshift-gitops-redis-ha-server-1 -n openshift-gitops
oc exec -it openshift-gitops-redis-ha-server-0 -n openshift-gitops -- \
sh -c 'REDISCLI_AUTH=$(cat /app/config/redis-auth/auth) redis-cli INFO replication'
oc exec -it openshift-gitops-redis-ha-server-0  -n openshift-gitops -- cat /data/conf/redis.conf

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 860a248c-6cd4-4858-88cb-b7e82315ab65

📥 Commits

Reviewing files that changed from the base of the PR and between fd47c94 and e51c650.

📒 Files selected for processing (1)

• build/redis/redis.conf.tpl

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• argoproj-labs/argocd-operator (manual)

---

📝 Walkthrough

Summary by CodeRabbit

• New Features
  • Added Redis replication authentication support through a configurable password placeholder.

Walkthrough

The Redis configuration template file is updated to include a masterauth directive with a placeholder value, enabling replication authentication configuration through variable substitution.

Changes

Redis Replication Auth

Layer / File(s)	Summary
Add masterauth directive build/redis/redis.conf.tpl	Inserts masterauth __REPLACE_DEFAULT_AUTH__ into the Redis configuration template to enable replication authentication via placeholder substitution.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the Redis masterauth regression and NOAUTH authentication error being fixed.
Description check	✅ Passed	The description directly explains the Redis masterauth regression and how the fix restores password injection.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[varshab1210]

/lgtm

[svghadi]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [svghadi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[akhilnittala]

/retest-required

[akhilnittala]

/retest

[openshift-ci]

@akhilnittala: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v4.14-kuttl-sequential	e51c650	link	false	/test v4.14-kuttl-sequential
ci/prow/v4.19-kuttl-parallel	e51c650	link	true	/test v4.19-kuttl-parallel
ci/prow/v4.14-e2e	e51c650	link	false	/test v4.14-e2e
ci/prow/v4.14-kuttl-parallel	e51c650	link	false	/test v4.14-kuttl-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.