fix: Target Down for metrics monitor

[akhilnittala]

What type of PR is this?
/kind bug

What does this PR do / why we need it:
Target Down alerts are firing because of https handling is not happening as kube-rbac-proxy image has been deprecated. Implemented metrics monitor to work for https from prometheus scraping from controller main code.
Have you updated the necessary documentation?

• Documentation update is required by this PR.
• Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?
https://redhat.atlassian.net/browse/GITOPS-10273
Test acceptance criteria:

• Unit Test
• E2E Test

How to test changes / Special notes to the reviewer:

Deploy gitops operator with namespace having openshift.io/cluster-monitoring:'true' label on openshift-gitops-operator namespace
check alerts and target all are up.

[coderabbitai]

Caution

Review failed

An error occurred during the review process. Please try again later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@cmd/main.go`:
- Line 184: The metrics server setup is rebuilding the TLS options instead of
using the already computed tlsOpts, so the HTTPS metrics listener misses the
cluster TLS profile. Update the buildMetricsServerOptions call in main to pass
the existing tlsOpts slice (which already includes disableHTTP2 and any cluster
profile settings) rather than constructing a new one inline. Use the nearby
tlsOpts setup and buildMetricsServerOptions to locate the change.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 85d3d968-67d1-40ed-a855-878bbfb9b3a2

📥 Commits

Reviewing files that changed from the base of the PR and between 93a8216 and b999418.

📒 Files selected for processing (6)

• bundle/manifests/gitops-operator.clusterserviceversion.yaml
• bundle/manifests/openshift-gitops-operator-metrics-service_v1_service.yaml
• cmd/main.go
• config/default/manager_metrics_patch.yaml
• config/manager/manager.yaml
• config/rbac/metrics_service.yaml

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• argoproj-labs/argocd-operator (manual)

[akhilnittala]

/retest-required

[svghadi]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [svghadi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[svghadi]

/lgtm

[akhilnittala]

/retest-required

[svghadi]

/test v4.14-images

[svghadi]

/retest

[svghadi]

/cherry-pick v1.21

[openshift-cherrypick-robot]

@svghadi: #1195 failed to apply on top of branch "v1.21":

Applying: fix: Target Down for metrics monitor
Using index info to reconstruct a base tree...
M	bundle/manifests/gitops-operator.clusterserviceversion.yaml
M	cmd/main.go
M	config/manager/manager.yaml
Falling back to patching base and 3-way merge...
Auto-merging bundle/manifests/gitops-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in bundle/manifests/gitops-operator.clusterserviceversion.yaml
Auto-merging cmd/main.go
CONFLICT (content): Merge conflict in cmd/main.go
Auto-merging config/manager/manager.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 fix: Target Down for metrics monitor

Details

In response to this:

/cherry-pick v1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.