fix: fix intermittent test failure in 1-023_validate_repo_server_tls

[jgwest]

What type of PR is this?
/kind failing-test

What does this PR do / why we need it:

• Fixes intermittent test failure in 1-023_validate_repo_server_tls
• AFAICT we are not waiting long enough for ArgoCD instance to become ready after modifying ArgoCD CR:

    status:
      conditions:
      - lastTransitionTime: "2026-06-22T06:00:17Z"
        message: 'Failed to load target state: failed to generate manifest for source
          1 of 1: rpc error: code = Unavailable desc = connection error: desc = "transport:
          authentication handshake failed: tls: failed to verify certificate: x509:
          certificate is valid for localhost, reposerver, not argocd-repo-server.test-1-23-custom.svc.cluster.local"'
        type: ComparisonError
      controllerNamespace: test-1-23-custom

Have you updated the necessary documentation?

• Documentation update is required by this PR.
• Documentation has been updated.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jgwest for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ba5b236d-74c0-4bed-8b39-659e5bb6c991

📥 Commits

Reviewing files that changed from the base of the PR and between 8fa22b8 and ad1219c.

📒 Files selected for processing (1)

• test/openshift/e2e/ginkgo/parallel/1-023_validate_repo_server_tls_test.go

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• argoproj-labs/argocd-operator (manual)

---

📝 Walkthrough

Summary by CodeRabbit

• Tests
  • Enhanced TLS server validation test with an additional readiness verification check to ensure proper configuration state before proceeding with subsequent test steps.

Walkthrough

An additional Eventually(...).Should(argocdFixture.BeAvailable()) readiness assertion is inserted into the repo server TLS e2e test after the TLS secret existence check, introducing a second reconciliation-ready wait for argoCDTest_1_23_custom before subsequent test steps.

Changes

TLS E2E Test Readiness Wait

Layer / File(s)	Summary
Extra readiness assertion after TLS secret check test/openshift/e2e/ginkgo/parallel/1-023_validate_repo_server_tls_test.go	Adds a second Eventually(argoCDTest_1_23_custom, "5m", "5s").Should(argocdFixture.BeAvailable()) call immediately following the TLS secret existence assertion.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the specific test being fixed and describes the main change as addressing an intermittent test failure.
Description check	✅ Passed	The description is directly related to the changeset, explaining the failing test, the root cause (ArgoCD instance not ready after CR modification), and the expected fix.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands.}

[olivergondza]

/test all

[olivergondza]

Original test run was successful. Rerunning to give the intermittence some change to show up

[olivergondza]

/retest

[openshift-ci]

@jgwest: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v4.14-kuttl-parallel	ad1219c	link	false	/test v4.14-kuttl-parallel
ci/prow/v4.14-kuttl-sequential	ad1219c	link	false	/test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.