fix(build): support configured collection expressions - #190
Open
ChrisPulman wants to merge 2 commits into
Open
Conversation
Update capacity- and comparer-based List, HashSet, and Dictionary construction to the C# 15 collection-expression syntax required by SST2106. Refresh centrally managed dependency versions and align the affected test setup code while preserving comparer and capacity semantics.
Replace the scheduler-sensitive five-second completion wait in the async-enumerable coverage test with TUnit's standard cancellation token and a 30-second per-test timeout.\n\nThis preserves the asynchronous enumeration path while preventing Windows multi-target runner contention from producing false failures.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 711 711
Lines 22078 22078
Branches 2703 2703
=======================================
Hits 21881 21881
Misses 196 196
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Build compatibility fix and centrally managed dependency refresh.
What is the new behavior?
with(...)for configured List, HashSet, and Dictionary construction required by SST2106.What is the current behavior?
The analyzer update reports SST2106 errors for direct collection constructors that specify capacity or comparer arguments, preventing solution builds.
Checklist
Additional information
dotnet build "ReactiveUI.Primitives.slnx" -c Debug --no-restore --no-incrementalcompleted with 0 warnings and 0 errors.dotnet build "ReactiveUI.Primitives.slnx" -c Release --no-restore --no-incrementalcompleted with 0 warnings and 0 errors.