Fix per-node memory regression caused by Grid styles - #2018
Closed
intergalacticspacehighway wants to merge 2 commits into
Closed
Fix per-node memory regression caused by Grid styles#2018intergalacticspacehighway wants to merge 2 commits into
intergalacticspacehighway wants to merge 2 commits into
Conversation
Style is held by value in every node. An empty std::vector still costs its three pointers, so the four grid track lists take 96 bytes even on a node with no tracks. Grid style now sits behind one pointer which stays null until a grid property is set. sizeof(Style): 280 -> 160.
intergalacticspacehighway
force-pushed
the
grid-style-size
branch
from
September 2, 2026 03:40
283361b to
abc669e
Compare
intergalacticspacehighway
marked this pull request as ready for review
September 2, 2026 03:47
facebook-github-tools
Bot
added
the
Shared with Meta
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D118628661. |
javache
pushed a commit
to javache/react-native
that referenced
this pull request
Sep 4, 2026
Summary: # Why Currently, grid style properties are stored in yoga style (`gridTemplateRows_`, `gridAutoColumns_` etc). These properties increase the size of style object from `152` bytes to `280` bytes (84% increase). The cost is added even when a node is not a grid container or a grid item. # How Move grid style properties behind a pointer that is lazily allocated, on the first grid property set. A node that doesn't use grid only adds the cost of this pointer (8 bytes). So style now costs 160 bytes (5% increase). The public API remains unchanged. # Tests A test is added to catch the style size regression and `tests/GridStyleTest.cpp` includes additional cases to assert unset style, copy and move behaviour. X-link: react/yoga#2018 Reviewed By: rubennorte Differential Revision: D118628661 Pulled By: javache
meta-codesync Bot
pushed a commit
to react/react-native
that referenced
this pull request
Sep 4, 2026
Summary: Pull Request resolved: #58311 # Why Currently, grid style properties are stored in yoga style (`gridTemplateRows_`, `gridAutoColumns_` etc). These properties increase the size of style object from `152` bytes to `280` bytes (84% increase). The cost is added even when a node is not a grid container or a grid item. # How Move grid style properties behind a pointer that is lazily allocated, on the first grid property set. A node that doesn't use grid only adds the cost of this pointer (8 bytes). So style now costs 160 bytes (5% increase). The public API remains unchanged. # Tests A test is added to catch the style size regression and `tests/GridStyleTest.cpp` includes additional cases to assert unset style, copy and move behaviour. Changelog: [Internal] X-link: react/yoga#2018 Reviewed By: rubennorte Differential Revision: D118628661 Pulled By: javache fbshipit-source-id: 185370e93bcf5b277b48c436ba3d06dada5a66fe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Currently, grid style properties are stored in yoga style (
gridTemplateRows_,gridAutoColumns_etc). These properties increase the size of style object from152bytes to280bytes (84% increase). The cost is added even when a node is not a grid container or a grid item.How
Move grid style properties behind a pointer that is lazily allocated, on the first grid property set. A node that doesn't use grid only adds the cost of this pointer (8 bytes). So style now costs 160 bytes (5% increase). The public API remains unchanged.
Tests
A test is added to catch the style size regression and
tests/GridStyleTest.cppincludes additional cases to assert unset style, copy and move behaviour.