Skip to content

Make ModalHostViewUtils header private (#58883) #58883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coado wants to merge 1 commit into from
+7 −4
Closed

Make ModalHostViewUtils header private (#58883) #58883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewState.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,13 @@
*/

#include "ModalHostViewState.h"
#include "ModalHostViewUtils.h"

namespace facebook::react {

ModalHostViewState::ModalHostViewState()
: screenSize(ModalHostViewScreenSize()) {}

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic ModalHostViewState::getDynamic() const {
return folly::dynamic::object("screenWidth", screenSize.width)(
Expand Down
5 changes: 2 additions & 3 deletions packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewState.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include <React/Graphics.h>
#include <React/RendererCore.h>
#include <react/renderer/graphics/Float.h>
#include "ModalHostViewUtils.h"

#ifdef RN_SERIALIZABLE_STATE
#include <folly/dynamic.h>
Expand All @@ -26,7 +25,7 @@ class ModalHostViewState final {
public:
using Shared = std::shared_ptr<const ModalHostViewState>;

ModalHostViewState() : screenSize(ModalHostViewScreenSize()) {}
ModalHostViewState();
ModalHostViewState(Size screenSize_) : screenSize(screenSize_) {};

#ifdef RN_SERIALIZABLE_STATE
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <react/renderer/graphics/Size.h>

Expand Down
Loading