Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123418519. |
meta-codesync
Bot
changed the title
coado
force-pushed
the
export-D123418519
branch
from
October 6, 2026 10:52
4ad44fb to
0c5feb5
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Oct 6, 2026
Summary: `AnimatedPropsSerializer.h`, `AnimatedPropsRegistry.h` and `AnimationBackendCommitHook.h` are implementation details of `AnimationBackend` with no users outside React Native, so lower them from "for frameworks" to private. `AnimationBackend.h` (for frameworks) previously included the registry and commit hook headers, which would leak private headers to its consumers, so we decouple them: - forward-declare `AnimatedPropsRegistry`, `AnimationBackendCommitHook` and `SurfaceUpdates`; - hold the commit hook through `std::unique_ptr` and define the destructor out of line; - make `commitUpdates` private; it is only called from within `AnimationBackend`. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D123418519
Summary: Pull Request resolved: react#58858 `AnimatedPropsSerializer.h`, `AnimatedPropsRegistry.h` and `AnimationBackendCommitHook.h` are implementation details of `AnimationBackend` with no users outside React Native, so lower them from "for frameworks" to private. `AnimationBackend.h` (for frameworks) previously included the registry and commit hook headers, which would leak private headers to its consumers, so we decouple them: - forward-declare `AnimatedPropsRegistry`, `AnimationBackendCommitHook` and `SurfaceUpdates`; - hold the commit hook through `std::unique_ptr` and define the destructor out of line; - make `commitUpdates` private; it is only called from within `AnimationBackend`. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D123418519
coado
force-pushed
the
export-D123418519
branch
from
October 6, 2026 10:56
0c5feb5 to
9ec1d48
Compare
|
This pull request has been merged in 1c7a66b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
AnimatedPropsSerializer.h,AnimatedPropsRegistry.handAnimationBackendCommitHook.hare implementation details ofAnimationBackendwith no users outside React Native, so lower them from "for frameworks" to private.AnimationBackend.h(for frameworks) previously included the registry and commit hook headers, which would leak private headers to its consumers, so we decouple them:AnimatedPropsRegistry,AnimationBackendCommitHookandSurfaceUpdates;std::unique_ptrand define the destructor out of line;commitUpdatesprivate; it is only called from withinAnimationBackend.Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D123418519