Repository navigation
Validate PerformanceObserver callbacks - #58239
Closed
OskarEichler wants to merge 1 commit into
Closed
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
|
@rubennorte has imported this pull request. If you are a Meta employee, you can view this in D123889539. |
|
@rubennorte merged this pull request in c2da175. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
PerformanceObservercurrently accepts missing and non-function callbacks, creating invalid instances that fail only when native delivery tries to invoke the stored value. Validate construction synchronously, distinguish an omitted required argument from an explicitly supplied non-function, and cover both error paths.Fixes #58238.
Changelog:
[GENERAL] [FIXED] - Reject missing and non-function PerformanceObserver callbacks during construction.
Test Plan:
git diff --checkpassed.Invalid constructor calls now throw synchronously as required; valid callers and UI behavior are unchanged.