Support committing debugger-frontend sync under Git checkouts (#57997) - #57997
Closed
huntie wants to merge 1 commit into
Closed
Support committing debugger-frontend sync under Git checkouts (#57997)#57997huntie wants to merge 1 commit into
huntie wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116031207. |
huntie
changed the title
huntie
changed the title
…57997) Summary: `scripts/debugger-frontend/sync-and-build` with `--create-diff` only worked under fbsource, making commit creation (in particular the generated changes table) inconvenient outside of Meta. This diff lifts commit creation functionality to both Git and Mercurial (`sl`), and makes writing a local commit the default behaviour. **Changes** - Synced `debugger-frontend` artifacts are now always committed, regardless of version control backend. Internal Mercurial behaviour is forked to a `fbsource-backend.fb.js` script. - `--create-diff` is narrowed to draft Phabricator diff submission (fbsource only). - The script now aborts if there are any working copy changes. Changelog: [Internal] Reviewed By: vzaidman Differential Revision: D116031207
meta-codesync
Bot
changed the title
huntie
force-pushed
the
export-D116031207
branch
from
August 18, 2026 13:59
2f7f8bd to
e7706e1
Compare
|
This pull request has been merged in 526016d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
scripts/debugger-frontend/sync-and-buildwith--create-diffonly worked under fbsource, making commit creation (in particular the generated changes table) inconvenient outside of Meta.This diff lifts commit creation functionality to both Git and Mercurial (
sl), and makes writing a local commit the default behaviour.Changes
debugger-frontendartifacts are now always committed, regardless of version control backend. Internal Mercurial behaviour is forked to afbsource-backend.fb.jsscript.--create-diffis narrowed to draft Phabricator diff submission (fbsource only).Changelog: [Internal]
Reviewed By: vzaidman
Differential Revision: D116031207