build: Only enable -Werror for debug builds#69
Closed
chewi wants to merge 1 commit into
Closed
Conversation
|
I updated the changes to be applicable to the current source set |
4 tasks
-Werror is very unhelpful for distributions and end users as newer compilers will raise warnings that the maintainers may not see. The warnings should get reported upstream, but they shouldn't block users from using the software. Rather than drop the flag entirely, I have enabled it only for debug builds, e.g. -DCMAKE_BUILD_TYPE=Debug. Signed-off-by: James Le Cuirot <chewi@gentoo.org>
Author
|
I've now rebased this and included the new |
pelwell
added a commit
that referenced
this pull request
May 27, 2026
Move the -Werror flag from being the default to a CMake build flag - ENABLE_WERROR - and set it in the workflow. Fixes: #69 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Collaborator
|
We took a different route. I hope this meets your needs. |
Author
|
It does, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Werroris very unhelpful for distributions and end users as newer compilers will raise warnings that the maintainers may not see. The warnings should get reported upstream, but they shouldn't block users from using the software.Rather than drop the flag entirely, I have enabled it only for debug builds, e.g.
-DCMAKE_BUILD_TYPE=Debug.