chore(deps): bump library/node from 22-bookworm-slim to 26-bookworm-slim in /apps/api - #1790
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps library/node from 22-bookworm-slim to 26-bookworm-slim. --- updated-dependencies: - dependency-name: library/node dependency-version: 26-bookworm-slim dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
|
Contributor
simple-agent-manager Bot
pushed a commit
that referenced
this pull request
Aug 17, 2026
Brings #1801, #1790, #1792, #1796 in as one reviewable unit and fixes what each Dependabot commit left half-done. #1801 @agentclientprotocol/sdk 0.25.0 -> 1.3.0: REMOVED instead of bumped. An exhaustive sweep (all file types, tsconfig paths/types, vite/vitest/eslint configs, every workspace package.json, Go modules) found zero importers. packages/acp-client hand-rolls its ACP payload types in src/hooks/useAcpMessagePayloads.ts and src/transport/types.ts, and transport/websocket.ts deliberately types the ACP payload as `unknown`. The canonical wire contract lives in the Go VM agent. Carrying a 1.3.0 dep whose deprecated ClientSideConnection/ndJsonStream surface implies an integration that does not exist is worse than carrying none. AGENTS.md claimed the SDK "defines the ACP wire protocol types" — corrected to describe reality. #1790 node 22 -> 26-bookworm-slim: taken, comment desync fixed. None of the seven globally-installed agent CLIs declares an engines.node upper bound, so no EBADENGINE is possible; the digest resolves to node 26.7.0 and bookworm is still published for 26. #1792 cloudflare/sandbox 0.12.1 -> 0.12.5: Dependabot moved only the image. The npm client stayed at ^0.12.1 while the Dockerfile comment still asserted they MUST match. Pinned @cloudflare/sandbox to exactly 0.12.5 — an exact pin, because a range lets the client drift from the digest-pinned image on any unrelated install. #1796 @astrojs/starlight 0.40.0 -> 0.41.7: root cause of all five red checks was peer astro@^7.0.2 vs pinned astro@6.4.8. The newer peer graph pulls @astrojs/mdx@7.0.5, which imports `chunkToString` from astro/runtime/server/index.js — absent in Astro 6. Upgraded astro to 7.2.2 (pinned in exactly one place, apps/www). Astro 7's rolldown pipeline then resolves dynamic imports inside processed <script> blocks, so the mermaid lazy-loader in BlogPost.astro needed is:inline; /scripts/blog-mermaid.js is an esbuild output emitted to public/ at build time, i.e. a runtime URL rather than a resolvable module. Build is clean: 181 pages + Pagefind + sitemap. Also corrects a bad @types/node resolution combo the lockfile text-merge produced across the two npm PRs. Process fix: the existing Docker governance test asserted digest pinning only, so it passed straight through BOTH stale-comment bugs. Adds two tests to scripts/quality/dependency-governance.test.ts — reviewed-source-tag comments must match their FROM tag, and @cloudflare/sandbox must be an exact pin equal to the image tag. Both verified discriminating: each goes red on the exact pre-fix state Dependabot produced.
Contributor
|
Blocking this from merge after major-version review. What I checked:
Why this cannot merge yet:
Local compatibility findings:
What needs to be addressed before merge:
I did not merge because CI is red and the runtime evidence above is missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps library/node from 22-bookworm-slim to 26-bookworm-slim.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)