Repository navigation
fix(assistant): restore streaming and model preparation actions - #259
Merged
Merged
Conversation
Stream validated local answers and drafts, batch chat updates, and preserve unfinished previews safely when providers reset. Keep preparation actions explicit and carry English locale preferences across editor entry points. Add four captioned English AI demos and document experimental model limitations.
Deploying document with
|
| Latest commit: |
b8a22b2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f7fa31ee.document-7hm.pages.dev |
| Branch Preview URL: | https://codex-assistant-streaming-de.document-7hm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Verdict
[APPROVE] — Ready for review with the AI assistant retained as an experimental feature.
Summary
Risk Analysis
@streamparser/jsonpackage. Bound preview input size, cover escaped text and Unicode chunk boundaries, and keep complete-schema validation outside the presentation parser.Design Decisions
Code Concerns
docs/media/ai-demos/README.md:3,docs/media/ai-demos/README.md:53). During recording, the default model gave incorrect content answers and failed to finish some replies after a PDF note was saved. The PDF demo therefore shows verified reading, proposal review and cancellation. Keep the experimental designation; review model quality separately from host/editor correctness.No outstanding merge-blocking findings were found in the reviewed changes. The stale browser assertion and unfinished-preview promotion discovered during submission review were fixed and verified.
Verification
Conclusion basis
pnpm run lint:ts,pnpm run format:check,pnpm run test:coverage, andE2E_PORT=4313 pnpm exec playwright test test/e2e/assistant-loading-locale.spec.ts test/e2e/agent-composer-ux.spec.ts test/e2e/agent-product-entry.spec.ts --workers=2.