Skip to content

Patches get silently overridden on package update / native compilation #62

Description

@sebmiq

Hi,

A few of my patches keep getting silently overridden, I assume because the original definition is reevaluated by native compilation.

Using advice as suggested in #60 would be one way to fix this, perhaps.

Activity

  1. raxod502 commented on Sep 29, 2022

    @raxod502
    Member

    Yes, that's a known issue. There are reasons to stick to the existing way of doing things, as mentioned in #60 (comment), but I suppose it would not be a bad idea to at least make it customizable whether the user would prefer for functions to be patched using advice rather than being overwritten.

  2. haji-ali commented on Jan 25, 2023

    @haji-ali
    Contributor

    See #63 for a possible implementation and further discussion on the pitfalls of advising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions