Repository navigation
Log the client IP Cloudflare forwards, not the edge address - #19
Merged
Merged
Conversation
Requests proxied through Cloudflare arrive from an edge address, so `request-client-ip` reported the proxy rather than the original client and every logged request looked like it came from Cloudflare. Prefer the CF-Connecting-IP header when it is present. Note that the header can be forged by anything that reaches the server directly, so this is only as trustworthy as the listening port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requests proxied through Cloudflare arrive from an edge address, so
request-client-ipreported the proxy rather than the original clientand every logged request looked like it came from Cloudflare. Prefer
the CF-Connecting-IP header when it is present.
Note that the header can be forged by anything that reaches the server
directly, so this is only as trustworthy as the listening port.