Repository navigation
Correctly infer TypeVarTuple against Any - #22140
Open
ilevkivskyi wants to merge 1 commit into
Open
ilevkivskyi wants to merge 1 commit into
ilevkivskyi wants to merge 1 commit into
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: scipy-stubs (https://github.com/scipy/scipy-stubs)
- tests/misc/test_submodules_empty.pyi:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
Member
Author
|
Btw @hauntsaninja do you have any ideas why we have the spurious diff from |
JukkaL
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22108
This has two parts:
TypeVarTuples.Anyis special-cased inexpand_type()(for convenience), but we should not abuse that.Any" special-casing toParamSpecandTypeVarTuple. These can't really be unions.Either of the two would be sufficient to fix the crash, but I apply them both, since both make sense on they own (even without the crash). Note I don't try to improve the inference here, I am just fixing the crash. We are already doing a decent inference here. Also the
ParamSpectest doesn't crash on master (since we don't infer it againstAnyATM), but it would be good to have it to prevent possible regressions.cc @JukkaL