Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mypyc/mypyc#1212.
mypyc stores a property's getter as a method under the property's name, and
gen_method_callchecks for a method before it checks for an attribute. Soobj.prop(x)on a native class was compiled as a direct call to the getter:xwas dropped, and the call returned the property's value instead of calling it. For the example in the issue, the IR was:This usually failed with a
TypeErrorlike the one in the issue (list object expected; got builtin_function_or_method). When the result type wasobjectorAny(for example withCallable[[], object]), it silently returned the callable itself.super().prop(x)had the same problem intranslate_super_method_call.Now neither place treats a property getter as the method to call.
obj.prop(x)calls the getter and then calls the value it returns, as mypyc already does for an attribute that holds a callable:super().prop(x)gets the value throughsuper(), assuper().propalready does..