Skip to content

gh-124111: Keep tests passing for Tcl prior to 9.0 #150102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 2 commits into from
May 19, 2026
+2 −4
Merged

gh-124111: Keep tests passing for Tcl prior to 9.0 #150102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51e8052
gh-124111: Keep tests passing for Tcl prior to 9.0
zooba May 19, 2026
e127c14
We no longer need to include UWP
zooba May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/reusable-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ permissions:

env:
FORCE_COLOR: 1
IncludeUwp: >-
true

jobs:
build:
Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_tcl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def test_eval_null_in_result(self):
def test_eval_surrogates_in_result(self):
tcl = self.interp
result = tcl.eval(r'set a "<\ud83d\udcbb>"')
if sys.platform == 'win32':
if sys.platform == 'win32' and tcl_version >= (9, 0):
self.assertEqual('<\ud83d\udcbb>', result)
else:
self.assertEqual('<\U0001f4bb>', result)
Expand Down Expand Up @@ -294,7 +294,7 @@ def test_evalfile_surrogates_in_result(self):
""")
tcl.evalfile(filename)
result = tcl.eval('set b')
if sys.platform == 'win32':
if sys.platform == 'win32' and tcl_version >= (9, 0):
self.assertEqual('<\ud83d\udcbb>', result)
else:
self.assertEqual('<\U0001f4bb>', result)
Expand Down
Loading