Skip to content

gh-84353: Preserve non-UTF-8 filenames when appending to ZipFile#150091

Merged
gpshead merged 4 commits into
python:mainfrom
serhiy-storchaka:zipfile-append-preserve-names
May 27, 2026
Merged

gh-84353: Preserve non-UTF-8 filenames when appending to ZipFile#150091
gpshead merged 4 commits into
python:mainfrom
serhiy-storchaka:zipfile-append-preserve-names

Conversation

@serhiy-storchaka
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka commented May 19, 2026 •
edited by bedevere-app Bot
Loading

@serhiy-storchaka serhiy-storchaka requested a review from gpshead May 19, 2026 16:02
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels May 19, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 19, 2026
Open
serhiy-storchaka and others added 3 commits May 19, 2026 19:56
@serhiy-storchaka
Simplify!!!
7d3a02f
@gpshead
Address review: clarify test naming and NEWS wording
828bc55 
- Rename bad_expected_names -> mojibake_expected_names in the append /
  comment tests.
- The comment on newname2 was potentially misleading: it is representable
  in cp437 but is still stored as UTF-8 (new entries default to UTF-8 flag).
- Reword the NEWS entry.
@gpshead
reword news again
38bc1b1
@gpshead gpshead enabled auto-merge (squash) May 27, 2026 17:28
@serhiy-storchaka
Copy link
Copy Markdown
Member Author

serhiy-storchaka commented May 27, 2026

I did not see suggestions, but all of them make sense. Thanks!

@gpshead gpshead merged commit 24c6bbc into python:main May 27, 2026
59 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented May 27, 2026

Thanks @serhiy-storchaka for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 27, 2026

GH-150527 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 27, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 27, 2026

GH-150528 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 27, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 27, 2026

GH-150529 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 27, 2026
serhiy-storchaka added a commit that referenced this pull request May 27, 2026
@miss-islington @serhiy-storchaka @gpshead
[3.13] gh-84353: Preserve non-UTF-8 filenames when appending to ZipFi…
dad9bec 
…le (GH-150091) (GH-150529)

Preserve non-UTF-8 filenames when appending to a ZipFile.

---------
(cherry picked from commit 24c6bbc)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
serhiy-storchaka added a commit that referenced this pull request May 27, 2026
@miss-islington @serhiy-storchaka @gpshead
[3.14] gh-84353: Preserve non-UTF-8 filenames when appending to ZipFi…
eb9c97b 
…le (GH-150091) (GH-150528)

Preserve non-UTF-8 filenames when appending to a ZipFile.

---------
(cherry picked from commit 24c6bbc)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
serhiy-storchaka added a commit that referenced this pull request May 27, 2026
@miss-islington @serhiy-storchaka @gpshead
[3.15] gh-84353: Preserve non-UTF-8 filenames when appending to ZipFi…
f216c89 
…le (GH-150091) (GH-150527)

Preserve non-UTF-8 filenames when appending to a ZipFile.

---------
(cherry picked from commit 24c6bbc)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @gpshead