gh-79413: Add qualname parameter to dataclass.make_dataclass.#150026
Merged
Conversation
Added `qualname` parameter to `dataclasses.make_dataclass` in order to allow user to set `__qualname__` for the generated class.
|
All commit authors signed the Contributor License Agreement. |
Documentation build overview
6 files changed ·
|
nedbat
reviewed
May 18, 2026
JelleZijlstra
changed the title
qualname parameter to dataclass.make_dataclass.qualname parameter to dataclass.make_dataclass.
- Added `versionadded:: next` for `qualname` parameter - Fixed formatting.
cmaloney
approved these changes
May 18, 2026
- Fix section on `qualname` parameter to link to `type.__qualname__`.
JelleZijlstra
approved these changes
May 18, 2026
ericvsmith
requested changes
May 18, 2026
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
- Add test case for `module.Class` for `qualname`. - Add test case for `qualname` not set.
ericvsmith
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #79413
Added
qualnameparameter todataclasses.make_dataclassin order to allow user to set__qualname__for the generated class.The
pickleissue mentioned in GH-79413 was resolved by #102104 which added themoduleargument however that PR did not include allowing the user to set__qualname__for the generated class. This PR resolves that remaining part of this issue.There should be no backwards compatibility issues - current code that calls
make_dataclasswithout thequalnameparameter will continue to create classes that use thecls_nameparameter as the__qualname__with no changes.