Skip to content

gh-149921: Fix reference leaks in _interpchannels and _interpqueues modules#149922

Merged
sobolevn merged 2 commits into
python:mainfrom
aisk:interpreter-decref
May 17, 2026
Merged

gh-149921: Fix reference leaks in _interpchannels and _interpqueues modules#149922
sobolevn merged 2 commits into
python:mainfrom
aisk:interpreter-decref

Conversation

@aisk
Copy link
Copy Markdown
Member

@aisk aisk commented May 16, 2026 •
edited by bedevere-app Bot
Loading

@aisk aisk requested a review from ericsnowcurrently as a code owner May 16, 2026 12:10
@bedevere-app bedevere-app Bot mentioned this pull request May 16, 2026
Closed
@aisk aisk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels May 16, 2026
@aisk aisk changed the title gh-149921: Fix reference leaks _interpchannels and _interpqueues modules gh-149921: Fix reference leaks in _interpchannels and _interpqueues modules May 16, 2026
sergey-miryanov
sergey-miryanov approved these changes May 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sergey-miryanov sergey-miryanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sobolevn
sobolevn approved these changes May 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit acefff9 into python:main May 17, 2026
63 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented May 17, 2026

Thanks @aisk for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 17, 2026

GH-149943 is a backport of this pull request to the 3.15 branch.

@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented May 17, 2026

Sorry, @aisk and @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker acefff95eab3db6b7cf837f3ce2707bbf9199376 3.13

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 17, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 17, 2026

GH-149944 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 17, 2026
@sobolevn
Copy link
Copy Markdown
Member

sobolevn commented May 17, 2026

@aisk can you please handle the 3.13 backport (if it is needed)?

sobolevn pushed a commit that referenced this pull request May 17, 2026
@miss-islington @aisk
[3.14] gh-149921: Fix reference leaks in _interpchannels and _interpq…
dc86a1b 
…ueues modules (GH-149922) (#149944)

gh-149921: Fix reference leaks in _interpchannels and _interpqueues modules (GH-149922)
(cherry picked from commit acefff9)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
sobolevn pushed a commit that referenced this pull request May 17, 2026
@miss-islington @aisk
[3.15] gh-149921: Fix reference leaks in _interpchannels and _interpq…
42ff9b4 
…ueues modules (GH-149922) (#149943)

gh-149921: Fix reference leaks in _interpchannels and _interpqueues modules (GH-149922)
(cherry picked from commit acefff9)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 17, 2026

GH-149954 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 17, 2026
@aisk aisk deleted the interpreter-decref branch May 17, 2026 13:13
sobolevn pushed a commit that referenced this pull request May 17, 2026
@aisk
[3.13] gh-149921: Fix reference leaks in _interpchannels and _interpq…
5531c77 
…ueues modules (GH-149922) (#149954)

(cherry picked from commit acefff9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergey-miryanov sergey-miryanov sergey-miryanov approved these changes

@sobolevn sobolevn sobolevn approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

@sobolevn sobolevn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aisk @sobolevn @sergey-miryanov