Skip to content

gh-149571: Make Element.itertext consistent for Comment and ProcessingInstruction#149714

Open
hardiksingh5864 wants to merge 3 commits into
python:mainfrom
hardiksingh5864:feature/bug
Open

gh-149571: Make Element.itertext consistent for Comment and ProcessingInstruction#149714
hardiksingh5864 wants to merge 3 commits into
python:mainfrom
hardiksingh5864:feature/bug

Conversation

@hardiksingh5864
Copy link
Copy Markdown

@hardiksingh5864 hardiksingh5864 commented May 12, 2026

This fixes a behavior mismatch between the pure-Python and C implementations of xml.etree.ElementTree.Element.itertext()
Added regression coverage in Lib/test/test_xml_etree.py

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 12, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@python-cla-bot
Copy link
Copy Markdown

python-cla-bot Bot commented May 12, 2026

All commit authors signed the Contributor License Agreement.

CLA signed

Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you ran a linter, causing a massive diff. Please revert the unrelated changes.

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 12, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants