gh-149427: Improve performance of re.compile() for patterns with character ranges#149428
Open
eendebakpt wants to merge 3 commits into
Open
gh-149427: Improve performance of re.compile() for patterns with character ranges#149428eendebakpt wants to merge 3 commits into
eendebakpt wants to merge 3 commits into
Conversation
Documentation build overview
43 files changed ·
|
Contributor
|
I confirm the numbers as of e7ca3ef
|
MojoVampire
reviewed
May 18, 2026
Contributor
There was a problem hiding this comment.
When av[0] and av[1] were only being accessed once, indexing overhead didn't matter much, and the meaning was more clear. But now we're using it a lot more. Perhaps change to start, end = av, end += 1, r = range(start, end), and then the non-fixup path can just use start and end in place of reindexing to av[0]/av[1] repeatedly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For details see the corresponding issue.
re.compile()for patterns with character ranges #149427