gh-149013: extend test_lazy_import coverage for reload() and sys.modu…#149014
Open
XiaoWan-zi wants to merge 4 commits into
Open
gh-149013: extend test_lazy_import coverage for reload() and sys.modu…#149014XiaoWan-zi wants to merge 4 commits into
XiaoWan-zi wants to merge 4 commits into
Conversation
…s.modules deletion
DinoV
requested changes
May 18, 2026
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Use lazy from json import ... instead of lazy import json so reload tests cover fresh bindings after reification, per review feedback.
Contributor
Author
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @DinoV: please review the changes made to this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add two tests to
test_lazy_importcovering post-reification import state transitions:test_reload_after_lazy_reification_keeps_single_module_objecttest_reimport_after_deleting_sys_modules_entry_creates_new_moduleDetails
importlib.reload()behavior after lazy reification.sys.modules["json"]:Files
Lib/test/test_lazy_import/__init__.pyTest
./python -m test test_lazy_importNotes
Test-only change; no interpreter behavior changes.