Repository navigation
Bundle SchemaStore base references for offline validation - #728
Closed
mayankdhingra02 wants to merge 1 commit into
Closed
mayankdhingra02 wants to merge 1 commit into
mayankdhingra02 wants to merge 1 commit into
Conversation
Bundle SchemaStore's base definitions and register their URI aliases for vendored schema validators. Preserve root resources and the existing reference retrieval behavior for custom and user-provided schemas. Keep reference-only schemas in the vendoring pipeline without generating standalone hooks. Add offline resolution and root-precedence regressions. Closes python-jsonschema#655 Signed-off-by: Mayank Dhingra <mayankdhingra02@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #655.
Bundle SchemaStore's shared
base.jsondefinitions and preload its downloadand canonical URI forms when validating vendored builtin schemas. Custom and
user-supplied schemas keep their existing reference retrieval behavior, and a
root schema registered at either URI keeps precedence.
The internal reference schema participates in the existing update/digest
pipeline without generating a standalone hook. README and changelog entries
describe the offline capability.
Current vendored snapshots do not reference
base.jsonyet. Regressionfixtures exercise that dependency through the builtin loader: all four
vendor-name/URI combinations fail without the fix, then validate offline with
the bundled definitions. Other cases cover custom/local retrieval and root
resource precedence.
Validation: the complete default
toxrun passed all 21 environments,including 17 pytest configurations across Python 3.10–3.14, minimum
dependencies, JSON5/pyjson5, optional formats, and the stdlib JSON fallback
(10,590 passes, 188 expected skips, zero failures; combined coverage 96%).
All configured pre-commit hooks and the strict Sphinx build passed. The hook
generator produced no changes. Wheel/sdist builds,
twine check, andcheck-sdist --inject-junkpassed; both distributions containbase.jsonandits matching SHA-256 file.