Skip to content

Add GitHub Funding schema and pre-commit hook - #727

Closed
ac1982 wants to merge 1 commit into
python-jsonschema:mainfrom
ac1982:feat/github-funding-hook
Closed

ac1982 wants to merge 1 commit into
python-jsonschema:mainfrom
ac1982:feat/github-funding-hook

Conversation

@ac1982

@ac1982 ac1982 commented Oct 14, 2026

Copy link
Copy Markdown

Closes #725.

Adds check-github-funding through the existing schema catalog and generators, with the SchemaStore schema bundled for --builtin-schema vendor.github-funding. The hook matches .github/FUNDING.yml. Includes generated usage documentation, a changelog entry, path matching tests, and positive/negative funding examples.

Validation: 12 focused tests passed; full suite 624 passed and 13 skipped (optional JSON5 support), with ambient NO_COLOR unset for the color-output tests. Mypy, strict Sphinx build, and applicable pre-commit checks passed. Built the wheel and exercised the hook through pre-commit: valid funding passed and an invalid username type failed.

AI assistance was used to implement and validate this change.

@sirosen

sirosen commented Oct 15, 2026

Copy link
Copy Markdown
Member

@sirosen sirosen closed this Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add check-github-funding pre-commit hook

2 participants