Improvements for type annotations - #669
Merged
Merged
Conversation
Pierre-Sassoulas
added this pull request to stack #670
September 29, 2026 13:27
Pierre-Sassoulas
force-pushed
the
future-annotations
branch
from
September 29, 2026 13:31
ff0fd1d to
a2664fb
Compare
nicoddemus
previously approved these changes
Sep 29, 2026
Pierre-Sassoulas
force-pushed
the
future-annotations
branch
from
September 29, 2026 14:24
a2664fb to
20d74be
Compare
Enforce it with ruff's required-imports (I002). Refs #610 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Runtime type aliases keep Optional, as they are still evaluated on Python 3.9. Refs #610 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #610 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pierre-Sassoulas
force-pushed
the
future-annotations
branch
from
September 29, 2026 14:34
20d74be to
a766f54
Compare
Member
Author
|
Review is required again only because I rebased on #668, I'll merge when test are green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #610