-
Notifications
You must be signed in to change notification settings - Fork 368
Fix mailoutbox fixture initialization with database-dependent fixtures
#1309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gh640
wants to merge
1
commit into
pytest-dev:main
Choose a base branch
from
gh640:fix/mailoutbox-fixture-initialization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -804,6 +804,23 @@ def test_mail_again(mailoutbox) -> None: | |||||
| test_mail(mailoutbox) | ||||||
|
|
||||||
|
|
||||||
| def test_mailoutbox_with_db(mailoutbox, db: None) -> None: # noqa: ARG001 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should have this test to make sure we don't regress yet again 😇 |
||||||
| assert mailoutbox is mail.outbox | ||||||
|
|
||||||
|
|
||||||
| @pytest.fixture | ||||||
| def mail_sending_db_fixture(db: None) -> None: # noqa: ARG001 | ||||||
| mail.send_mail("subject", "body", "from@example.com", ["to@example.com"]) | ||||||
|
|
||||||
|
|
||||||
| def test_mailoutbox_with_db_dependent_fixture( | ||||||
| mailoutbox, | ||||||
| mail_sending_db_fixture: None, # noqa: ARG001 | ||||||
| ) -> None: | ||||||
| assert mailoutbox is mail.outbox | ||||||
| assert len(mailoutbox) == 1 | ||||||
|
|
||||||
|
|
||||||
| def test_mail_message_uses_mocked_DNS_NAME(mailoutbox) -> None: | ||||||
| mail.send_mail("subject", "body", "from@example.com", ["to@example.com"]) | ||||||
| m = mailoutbox[0] | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Darn you're right, i'm tempted to not do this and set the
mail.outbox = []myself here, to not instantiate the db.@bluetech thoughts?