Repository navigation
Fix Hikvision default elevation configuration - #428
Merged
MateoLostanlen merged 2 commits intoOct 12, 2026
Merged
Conversation
Member
|
Thanks @fraztto for catching this, the fix is correct and the tests cover it well (9 of the 11 fail with the old line restored). One request before merging: please rebase onto Small optional nit: the parametrized cases could be trimmed to timeout only and elevation only, plus the preset move test. Not blocking. The two failing checks look unrelated: |
Contributor
Author
|
Yeah, sorry about that. I've changed the base to develop. Thanks |
fraztto
force-pushed
the
fix/hikvision-default-elevation
branch
from
October 11, 2026 19:06
de1d89a to
3b02b4e
Compare
MateoLostanlen
self-requested a review
October 12, 2026 12:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hikvision/Linovision registry reads
timeoutintodefault_elevation_deg.Setting elevation to -4.5° and timeout to 9 seconds therefore uses 9° for mapped
preset moves. Read elevation from its own configuration key instead.
Rebased onto current
develop(48ad5f1); the PR targetsdevelop. Per review,trim the parameterized cases to timeout-only and elevation-only for both aliases,
plus the mapped preset movement test. Startup ISAPI and movement execution are
mocked. All five focused tests and Ruff/format checks pass on Python 3.11.
New CI runs were triggered by the updated head. GitHub currently requires maintainer
approval for these workflows before execution.
The rebased full camera suite also passes locally: 82 passed, seven skipped.