fix(installer): accept Roku delete succeeded response#50
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the native Roku developer-installer delete flow to recognize the newer success phrasing "Delete Succeeded.", ensuring deleteInstalledChannel treats that response as a successful uninstall instead of a false failure.
Changes:
- Extend
isDeleteSuccessto accept installer delete messages containingsucceeded(in addition tosuccess/successful). - Add a regression test covering the HTML-wrapped
"Delete Succeeded."response path through the native installer request/response handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/installer-message.ts |
Expands delete-success message matching to include "succeeded" for recognized installer messages. |
test/roku-capture.test.ts |
Adds a regression test ensuring "Delete Succeeded." responses are accepted as successful deletes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
putio-release-bot Bot
added a commit
that referenced
this pull request
Jul 14, 2026
## [2.4.1](v2.4.0...v2.4.1) (2026-07-14) ### Bug Fixes * **installer:** accept Roku delete succeeded response ([#50](#50)) ([55f3f25](55f3f25))
Contributor
|
🎉 This PR is included in version 2.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept the success wording returned by current Roku developer installers when deleting a sideloaded channel.
Changed
Delete Succeeded.as a successful delete responseRisks
Low. The additional wording is accepted only when a recognized delete verb precedes
succeeded; unrelated HTTP 200 bodies remain failures.Verification
Delete Succeeded.and completed successfullyFollow-Ups
None.