Skip to content

(TESTS-1654) Add optional VERSION clause to CREATE EXTENSION - #1711

Closed
jst-cyr wants to merge 1 commit into
mainfrom
TESTS-1654
Closed

jst-cyr wants to merge 1 commit into
mainfrom
TESTS-1654

Conversation

@jst-cyr

@jst-cyr jst-cyr commented Oct 2, 2026

Copy link
Copy Markdown
Member

This PR is created to execute tests for the original PR (#1654)

Co-authored-by: Marco Lucarelli <marco.lucarelli@abacus.ch>
@jst-cyr

jst-cyr commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-postgresql/actions/runs/37061237668?pr=1711

Full red across the board. Some are expected (Debian 11 and Red Hat 7) but other failures appear to be caused by the changes in this PR.

Initial inspection sees two errors, at least:

  1. apply_manifest is rejecting having both catch_failures and expect_changes being passed
  2. spec/acceptance/extension_spec.rb needs postgresql-contrib, but that package seems to be missing on several platforms. If the tests don't need to excercise that path, might be worth revisiting the test. Otherwise, the requirements for the test need to be updated to ensure the needed packages are there.

@jst-cyr jst-cyr closed this Oct 5, 2026
@jst-cyr
jst-cyr deleted the TESTS-1654 branch October 5, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant