Skip to content

Fix Dependabot auto-approve when update-type is empty - #54

Merged
proxymeshai merged 3 commits into
mainfrom
cursor/dependabot-null-update-type-c08c
Sep 4, 2026
Merged

Fix Dependabot auto-approve when update-type is empty#54
proxymeshai merged 3 commits into
mainfrom
cursor/dependabot-null-update-type-c08c

Conversation

@proxymeshai

@proxymeshai proxymeshai commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

Stopped after Dependabot #41 (scrapy): CI was green and auto-merge was already enabled, but the approve step never ran because dependabot/fetch-metadata v2.5.0 left update-type empty for pip requirement-range bumps.

Fix

No custom title parsing and no PR code checkout.

  1. Bump dependabot/fetch-metadata to v3.1.0 — upstream restores update-type for pip/composer requirement bumps (in /dir regex + title fallback inside the action).
  2. Split Dependabot groups — replace dev-all with:
    • dev-minor-patch (auto-merge eligible)
    • dev-major (manual review)
  3. Eligibility (metadata / group only):
    • Block explicit semver-major
    • Allow explicit minor/patch
    • If update-type is empty: allow only prod-minor-patch / dev-minor-patch
    • Otherwise fail closed

Keeps skip-commit-verification so branch updates still work.

After merge

Resume updating open Dependabot PR branches one at a time.

Slack Thread

Open in Web Open in Cursor 

Pip requirement-range bumps often leave fetch-metadata update-type empty,
so the minor/patch allowlist skipped approve on those PRs. Keep blocking
explicit majors, and for empty update-type fall back to non-major
dependency groups or from/to versions in the PR title.

Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
@proxymeshai
proxymeshai marked this pull request as ready for review September 3, 2026 23:41

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 01b464e. Configure here.

Comment thread .github/workflows/dependabot-auto-merge.yml
dev-all includes majors, so do not auto-approve from the group name alone
when update-type is missing. Only prod-minor-patch is trusted as a group
shortcut; everything else requires same-major title parsing.

Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
@proxymeshai

Copy link
Copy Markdown
Collaborator Author

@cursoragent bugbot review

@cursor

cursor Bot commented Sep 4, 2026

Copy link
Copy Markdown

Bugbot finding is already fixed on head 886bdcf; CI is green and the review thread is resolved/outdated. No further code changes needed.

Finding: empty update-type used to auto-approve every dev-all PR, but that group includes majors.

Fix in place: only prod-minor-patch is trusted as a group shortcut. dev-all and everything else fall through to same-major title parsing (or fail closed).

Re-review of current head: no new blockers. Still fail-closed for:

  • explicit majors
  • dev-all group bumps with empty metadata and no parseable from/to title
  • unclassified titles (e.g. single-component versions like from 4 to 5)

Scrapy-style titles (Update scrapy from >=2.14.2 to >=2.18.0) still allow correctly. Ready for human review.

Open in Web Open in Cursor 

Bump dependabot/fetch-metadata to v3.1.0 so pip/composer requirement
bumps populate update-type again. Split dev-all into dev-minor-patch
(auto) and dev-major (manual) so empty update-type can trust group
membership. Drop custom title parsing from the workflow.

Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
@proxymeshai

Copy link
Copy Markdown
Collaborator Author

@cursoragent bugbot review

@cursor

cursor Bot commented Sep 4, 2026

Copy link
Copy Markdown

Bugbot re-review (head 5d2ff00): no new blockers.

The earlier finding (“dev-all allows majors on empty update-type”) is obsolete — that group is gone.

Current head is sound:

  • fetch-metadata v3.1.0 should restore update-type for pip/composer bumps
  • Empty update-type only trusts prod-minor-patch / dev-minor-patch (both exclude majors)
  • dev-major and actions fail closed unless update-type is explicitly minor/patch
  • Explicit majors always blocked
  • No title parsing, no PR code checkout

CI is green. Ready for human review.

Open in Web Open in Cursor 

@proxymeshai
proxymeshai merged commit c487710 into main Sep 4, 2026
10 checks passed
@proxymeshai
proxymeshai deleted the cursor/dependabot-null-update-type-c08c branch September 4, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants