Repository navigation
counter: cache entries for saved positional-label children - #865
Open
SidheshwarSarangal wants to merge 1 commit into
Open
SidheshwarSarangal wants to merge 1 commit into
SidheshwarSarangal wants to merge 1 commit into
Conversation
Invalidate cached entries after reset or removal. Preserve object-label and exemplar behavior, and add lifecycle tests and benchmarks. Relates to prometheus#863 Signed-off-by: Sidheshwar Sarangal <sidheshwar.sarangal@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saved counter children currently validate labels and rebuild the storage key on every increment. Cache the entry for positional string/number labels, invalidating it after
reset()orremove().Object-form labels and exemplar-enabled counters retain their existing paths. Add lifecycle tests and comparison benchmarks.
Relates to #863.
Validation
npm test -- --runInBand: 31 suites, 671 tests, and 34 snapshots passed.Direct increments varied by approximately 2% in this run.
AI assistance was used to prepare the implementation, tests, and benchmark helper.
@jdmarshall, could you review whether this scope fits the direction of #863?