Skip to content

fix(auth): validate verify sms phone strings #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Jul 30, 2026
Merged

fix(auth): validate verify sms phone strings #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/app/api/auth/verify-sms/route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ export async function POST(request, { params } = {}) {
return NextResponse.json({ error: 'Invalid request format' }, { status: 400 });
}

if (phoneNumber !== null && phoneNumber !== undefined && typeof phoneNumber !== 'string') {
return NextResponse.json({ error: 'Phone number must be a string' }, { status: 400 });
}

logger.info('SMS verification request received', {
phoneNumber: phoneNumber ? `${phoneNumber.substring(0, 3)}***${phoneNumber.substring(phoneNumber.length - 2)}` : null,
hasCode: !!verificationCode,
Expand Down
15 changes: 15 additions & 0 deletions src/app/api/auth/verify-sms/route.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,21 @@ describe('verify-sms session phone binding', () => {
expect(mocks.getUser).not.toHaveBeenCalled();
});

it('rejects non-string phone numbers before session validation', async () => {
const { POST } = await import('./route.js');
const res = await POST(sessionRequest({
useSession: true,
phoneNumber: 15559999999,
username: 'alice'
}));
const body = await res.json();

expect(res.status).toBe(400);
expect(body.error).toBe('Phone number must be a string');
expect(mocks.serverClient).not.toHaveBeenCalled();
expect(mocks.getUser).not.toHaveBeenCalled();
});

it('rejects anonymous / phoneless sessions', async () => {
mocks.getUser.mockResolvedValue({
data: { user: { id: 'anon', phone: null } },
Expand Down
Loading