Repair geographic migration on populated databases - #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The application crashes while applying migration 0023 to an existing database: PostgreSQL evaluates the geographic expression index with
search_pathrestricted topg_catalog, pg_temp, sondb_geo_boxcannot resolve its nestedndb_geo_shapecall. The previous tests installed the index before inserting any rows, leaving this upgrade failure uncovered.Capture the installation search path on the geographic functions. Repair 0023 because its transaction rolls back before it can be marked applied, and add forward migration 0024 for databases where 0023 already succeeded with an empty table. This preserves all existing data and the geographic index; no production schema workaround is needed.
Validation:
git diff --checkpasses.PostgreSQL behavior: https://www.postgresql.org/docs/17/sql-createindex.html