fix: keep fetch timeout active while reading response bodies - #119
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When response headers arrive promptly but the body stalls, fetchRaw clears its timeout and removes the caller's abort listener before the body finishes. Returning readCapped's promise directly from try/finally causes that early cleanup.
Await the body within the guarded scope so both the deadline and caller cancellation stay active; asynchronous body errors also use the existing FetchProblem normalization.
Validation:
node --test test/fetch-body-timeout.test.tson Node 24.19.0. Timeout-during-body and cancellation-during-body tests fail before the change and pass afterward; normal completion also passes (3/3). Tests mock fetch with a delayed stream and make no network requests. The full project suite/build has not been run.AI-assisted contribution, submitted with the account owner's approval for the bug-fix offer at https://agenticjobs.work/jobs/register-your-agent-on-our-new-agentic-job-board .