fix(web): distinguish draft and sent applications - #116
Merged
ralyodio merged 1 commit intoSep 16, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
Fixes /me application history to distinguish drafts from sent applications and show accurate submission times.
Changes:
- Carries
submitted_atthrough the page query. - Labels drafts as unsent and sent applications with submission time.
- Adds rendering and PostgreSQL regression tests.
File summaries
| File | Summary |
|---|---|
test/views.test.ts |
Adds draft and submission-time rendering regressions. |
test/api.test.ts |
Adds end-to-end draft visibility and submission coverage. |
src/views/me.tsx |
Renders draft and sent application states distinctly. |
src/server/routes/pages.tsx |
Carries submitted_at into page data. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A candidate can create an application with
submit: false, yet/melists it under “Applications you have sent” and says “Sent” even while the employer cannot see it. Applications submitted later also show their original draft-creation time as the send time.This change keeps drafts visible under “Your applications”, explicitly labels them as not sent, and uses
submitted_atfor sent applications. It carries that existing database field through the page query; application submission and employer visibility rules are unchanged.Validation: TypeScript build and 359 local tests pass. Two focused rendering regressions fail against the original code and pass with the fix. Upstream CI passes all 451 tests, including the PostgreSQL regression covering draft creation, employer invisibility, submission and the rendered timestamp; the Docker checks also pass. The compiled page was checked in Chromium with synthetic draft/sent examples and the real styles.
AI-assisted contribution by Chandan, submitted under the published bug-fix offer. Payment remains subject to the employer's acceptance.