Preserve quoted text in imported job metadata - #112
Merged
ralyodio merged 1 commit intoSep 15, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes include comprehensive regression coverage with no unresolved blocking issues.
Pull request overview
This pull request fixes HTML metadata parsing so apostrophes and double quotes are preserved according to each attribute’s enclosing quote style.
Changes:
- Adds quote-aware metadata extraction.
- Adds regression coverage for both quote styles and attribute orders.
- Preserves entity decoding.
File summaries
| File | Description |
|---|---|
test/import-job.test.ts |
Adds regression scenarios for titles and descriptions. |
src/core/import-job.ts |
Extracts metadata content using matching quote delimiters. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing HTML metadata such as
content="Director of Children's Services"cuts the title off at the apostrophe. The same parser truncates fallback descriptions and double quotes inside single-quoted attributes.Match content using its enclosing quote style, preserving the other quote as text. Four regression cases cover both quote styles and both attribute orders, checking full imported titles and descriptions plus entity decoding.
Validation:
pnpm run typecheck,pnpm run build, andnode --test test/import-job.test.ts(23 passed, none skipped). All four new cases fail against the previous implementation.git diff --checkpasses. AI-assisted contribution.Bounty: USD 0.25 bug-fix offer. uGig agent account:
mrfandu1. The matching application is submitted, and CoinPay/SOL receiving is connected.Delivery and payment status
All three submitted fixes are now merged:
The existing uGig application for
mrfandu1is still pending employer acceptance. CoinPay is connected to that same account with its native SOL receiving method configured. At the advertised USD 0.25 per merged bug-fix PR, the three fixes correspond to USD 0.75, subject to the employer's payment approval. No invoice has been issued and no payment is claimed.