Close fences only on a marker at least as long as the opener - #109
Merged
Merged
Conversation
A four-backtick block containing a three-backtick line ended early and its tail rendered as markup. The closing fence now requires the same character and at least the opening length, per CommonMark. toPlainText strips fenced blocks with the same length rule. Closes profullstack#106
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #106.
A fenced block opened with four backticks ended at the first three-backtick line inside it, so the rest of the code leaked out and rendered as markup (
**literal**became bold prose). The closing-fence check now requires the same marker character and at least the opening length, which is the CommonMark rule and the reason longer fences exist.toPlainTextstrips fenced blocks with the same length rule so feeds and snippets agree with the renderer.Verified: 323 tests pass, including new regression tests covering a short fence inside a long one, a longer closer for a shorter opener, and a tilde run inside a backtick fence.