fix(prism): avoid requiring full laravel framework#1025
Open
MiddleSokilAI wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
prism-php/prismcurrently requires the fulllaravel/frameworkpackage at runtime. Packages that only need Prism throughlaravel/aithen install the complete Laravel framework even when the host application already provides the required Illuminate components.Change Summary
laravel/frameworkruntime requirement with the concrete Illuminate components used bysrc/.Validation
composer.jsonsuccessfully with PowerShellConvertFrom-Json.git diff --checksuccessfully.src/Illuminate namespace usage against the listed component packages.Risk
Low-to-medium. This changes dependency metadata only, but consumers relying on Prism to implicitly install unrelated Laravel framework classes may need to require those packages directly.