fix: update download path in workflow - #222
Merged
joshblack merged 2 commits intoSep 4, 2026
Merged
Conversation
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The workflow change aligns the downloaded artifact location with the scripts’ expected results/... paths and is low-risk/config-only.
Pull request overview
This PR fixes where GitHub Actions extracts the “plan” artifact in the experiment and benchmark workflows so the subsequent shard steps can find plan.json under the expected results/... directory layout.
Changes:
- Set
actions/download-artifactpath: resultswhen downloading the experiment plan artifact. - Set
actions/download-artifactpath: resultswhen downloading the benchmark plan artifact.
File summaries
| File | Description |
|---|---|
| .github/workflows/experiment.yml | Downloads the experiment plan artifact into results/ so script/run-experiment.sh … shard can find results/experiments/<name>/<date>/plan.json. |
| .github/workflows/benchmark.yml | Downloads the benchmark plan artifact into results/ so script/run-benchmark.sh … shard can find results/benchmarks/<name>/<date>/plan.json. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
joshblack
deleted the
copilot/fix-7143434-1240100927-773f7e14-145d-4a58-824a-9fd82128b538
branch
September 4, 2026 15:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the download path in experiment and benchmark workflows to download the plan as expected