ci: migrate workflows to pnpm setup - #220
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b318a9ae-ca45-463b-9467-f731bdb4acf5
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The workflow updates are consistent with existing repo workflows using pnpm/setup and appear to correctly remove redundant caching/install steps without changing job semantics.
Review tier: Lite
Findings: None
What changed in this PR
This PR standardizes the benchmark and experiment GitHub Actions workflows on the pinned pnpm/setup action, matching the repository’s existing workflow pattern for dependency install + caching behavior.
Changes:
- Replace
pnpm/action-setupwith pinnedpnpm/setupin benchmark and experiment workflows. - Remove redundant
actions/setup-nodepnpm cache configuration and explicitpnpm install --frozen-lockfilesteps. - Enable
pnpm/setupcaching and lockfile enforcement viacache: trueandrequire-lockfile: true.
| File | Description |
|---|---|
| .github/workflows/experiment.yml | Migrates experiment jobs to pnpm/setup and removes redundant pnpm caching/install steps. |
| .github/workflows/benchmark.yml | Migrates benchmark jobs to pnpm/setup and removes redundant pnpm caching/install steps. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the remaining benchmark and experiment jobs from
pnpm/action-setuptopnpm/setupso our workflows use the same dependency installation and caching behavior.This is a change to our internal workflow and has no public facing impact.
Changelog
New
Changed
pnpm/setupaction.Removed
pnpm/action-setupreferences.